Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(refactor) billing services #750

Merged
merged 4 commits into from
Sep 28, 2016
Merged

(refactor) billing services #750

merged 4 commits into from
Sep 28, 2016

Commits on Sep 27, 2016

  1. fix(billingServices): cancel btn does not validate 

    This commit tells angular not to validate the form when the cancel
button is pressed.

Closes Third-Culture-Software#700.
    Jonathan Niles committed Sep 27, 2016
    Configuration menu
    Copy the full SHA
    a712e38 View commit details
    Browse the repository at this point in the history

  2. refactor(billingServices): update js/html to 2.x 

    This commit updates the HTML and JS for billing services to 2.x
standards.  In particular:
 1. The ui-grid uses descriptive links instead of buttons
 2. Notify catches HTTP errors
 3. Cleaned up controller imports
 4. Submit button conforms to standards
    Jonathan Niles committed Sep 27, 2016
    Configuration menu
    Copy the full SHA
    734c467 View commit details
    Browse the repository at this point in the history

  3. refactor(billingServices): better state management 

    This commit improves the ui-router state management by implementing a
more expressive URL syntax.  It migrates all routes out off app.js and
moves them to `billing_services.routes.js`.

It also makes sure Notify catches delete errors, which apparently
wasn't happening.

Closes Third-Culture-Software#699.
    Jonathan Niles committed Sep 27, 2016
    Configuration menu
    Copy the full SHA
    f9ee3c8 View commit details
    Browse the repository at this point in the history

  4. feat(billingServices): highlight targetted row 

    This commit implements highlighting on ui-grid rows to draw attention to
them.  The color and duration can be edited in the bhima-bootstrap.less
files.  For the moment, it flashes informational blue for 1.5 seconds.
    Jonathan Niles committed Sep 27, 2016
    Configuration menu
    Copy the full SHA
    8d9e695 View commit details
    Browse the repository at this point in the history