Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(bug) Billing Services modal "Cancel" button submits the form. #700

Closed
jniles opened this issue Sep 9, 2016 · 0 comments
Closed

(bug) Billing Services modal "Cancel" button submits the form. #700

jniles opened this issue Sep 9, 2016 · 0 comments
Assignees
@jniles
Labels
Bug

Comments

@jniles
Copy link
Collaborator

jniles commented Sep 9, 2016

When the billing services modals are dismissed, the form in the modal is submitted. For the Create state, this makes the form show red errors around the inputs as the modal is dismissed. For the Update state, this makes the Loading state appear on the button as the modal is dismissed.

Steps to Reproduce

  1. Navigate to #/admin/billing_services.
  2. Click the "Create" button.
  3. Click the "Cancel" button on the modal.

Expect Result The modal should close without error
Actual Result The modal flashes red and disappears
@jniles jniles added the Bug label Sep 9, 2016
@jniles jniles added this to the Finance Implementation milestone Sep 9, 2016
@jniles jniles self-assigned this Sep 27, 2016
jniles pushed a commit to jniles/bhima that referenced this issue Sep 27, 2016
fix(billingServices): cancel btn does not validate
a712e38 
This commit tells angular not to validate the form when the cancel
button is pressed.

Closes Third-Culture-Software#700.
@jniles jniles mentioned this issue Sep 27, 2016
Merged
4 tasks
jniles pushed a commit that referenced this issue Sep 28, 2016
@jniles
fix(billingServices): cancel btn does not validate
d0bd883 
This commit tells angular not to validate the form when the cancel
button is pressed.

Closes #700.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jniles jniles

Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jniles