Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Headers supported for iOS #2012

Closed
ThomasCarca opened this issue May 19, 2020 · 1 comment · Fixed by #2014
Closed

Headers supported for iOS #2012

ThomasCarca opened this issue May 19, 2020 · 1 comment · Fixed by #2014

Comments

@ThomasCarca
Copy link

Feature Request

Hello, My team has been using your library for different features and it is very useful to us, thank you !

We've recently come across the necessity to fetch a video with Authorization headers containing an authentication token and realized this was once possible for both android and iOS using the headers props but is no longer supported now.
The reason, as I understood, is the used API is private and it could cause the app to be rejected upon submission to the store. (see this issue)

Why it is needed

My team and I would very much like this feature implemented or any hint on a workaround in the meantime as it delivers a lot of value for our product.

Possible implementation

We have, unfortunately no idea whatsoever on a possible implementation.

Thank you for your time !

Archigog pushed a commit to Archigog/react-native-video that referenced this issue May 19, 2020
@jenshandersson
Copy link
Contributor

I feel we should add back AVURLAssetHTTPHeaderFieldsKey as this is not a private function and thus shouldn't lead to rejection. Expo are using this in their code as well. We've been setting AVURLAssetHTTPHeaderFieldsKey in our app and not got rejected. I will raise a PR for it.

https://github.com/expo/expo/blob/ee5af9cb39695818cd0bd860e083c08ad5bd3532/packages/expo-av/ios/EXAV/EXAVPlayerData.m#L116

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants