Change: Use Unique Dust Effect For Quad Cannon #372
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will take a look at it later and leave my 2 cents afterwards. |
|
1.04 Dust 2021-09-18.10-52-22.mp4Changed Dust 2021-09-18.10-48-50.mp4It's quite a big visual difference. |
|
I would say we leave particle effect as Original. The particle change is quite obvious and potentially bothers people, because it is brighter and larger. |
|
Agreed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #340
Apparently there is a unique dust effect for the Quad Cannon. In ZH 1.04, it shares the effect with the Rocket Buggy (and many other units).
I do not know if this effect looks better or not.