Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed up Quad Cannon draw code #340

Closed
wants to merge 1 commit into from
Closed

Fixed up Quad Cannon draw code #340

wants to merge 1 commit into from

Conversation

Generalcamo
Copy link
Collaborator

@Generalcamo Generalcamo commented Sep 13, 2021 •
edited by commy2
Loading

  • Fixed radar dish animation wasn't showing. ~commy2
  • Level 1 salvaged quad cannon now properly uses damaged model
  • Corrected dust trail to use the Quad Cannon's particle rather than the Rocket buggy's

@Generalcamo Generalcamo added the Bug Something is not working right label Sep 13, 2021
@Generalcamo Generalcamo self-assigned this Sep 13, 2021
@xezon xezon self-requested a review September 13, 2021 12:57
xezon
xezon requested changes Sep 13, 2021
View reviewed changes
Patch104pZH/GameFilesEdited/Data/INI/Object/ChemicalGeneral.ini
@@ -16607,11 +16607,14 @@ Object Chem_GLAVehicleQuadCannon
;UpgradeCameo4 = XXX
;UpgradeCameo5 = XXX

; Patch 1.04p @bugfix GeneralCamo 13/09/2021 - Fixed animations, set dust trail to the correct particle, and corrected salvage level 1 to properly use damaged model
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use Patch104p as opposed to Patch 1.04p in your comments so it is consistent with the keyword of all other comments we added.

@commy2
Copy link
Collaborator

commy2 commented Sep 13, 2021

What does "animation playback" mean here?

This is missing the GC Quads.

@Generalcamo
Copy link
Collaborator Author

@xezon Will commit a fix.

@commy2 I'll add the GC Quads and the CINE quads. Specifically, the Quad Cannons have an animation for their radar dishes. It currently does not play at all however, and this code fixes that.

@commy2
Copy link
Collaborator

commy2 commented Sep 13, 2021

Nice, dishes. Yumm.

No need to fix the CINE ones.

This was referenced Sep 16, 2021
Merged
Closed
Closed
@xezon xezon closed this Sep 18, 2021
@xezon xezon added Invalid Invalid and removed Bug Something is not working right labels Sep 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xezon xezon xezon requested changes

Assignees
No one assigned
Labels
Invalid Invalid
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Generalcamo @commy2 @xezon