Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Vanilla China Outposts Missing Detection Effect; Non-Vanilla China Outposts Missing Detection Sound Effect #349

Merged
merged 3 commits into from
Sep 16, 2021
Merged

Fix: Vanilla China Outposts Missing Detection Effect; Non-Vanilla China Outposts Missing Detection Sound Effect #349

merged 3 commits into from
Sep 16, 2021

Conversation

commy2
Copy link
Collaborator

@commy2 commy2 commented Sep 13, 2021 •
edited
Loading

ZH 1.04

  • The normal China Listening Outposts is not displaying the red grid below a detected object and the red ring around the unit that the other Listening Outposts have.

After patch:

  • All Listening Outposts use the same effects.

@commy2 commy2 added the Bug Something is not working right label Sep 13, 2021
@xezon xezon requested review from xezon and alanblack166 and removed request for xezon September 13, 2021 19:50
@commy2 commy2 changed the title Fix: Vanilla China Outposts Missing Detection Effect Fix: Vanilla China Outposts Missing Detection Effect; Non-Vanilla China Outposts Missing Detection Sound Effect Sep 16, 2021
@commy2 commy2 merged commit f073c0a into main Sep 16, 2021
@commy2 commy2 deleted the fix-outpost-detection-effect branch September 16, 2021 19:12
commy2 added a commit that referenced this pull request Oct 1, 2021
@commy2
Fix: Vanilla China Outposts Missing Detection Effect; Non-Vanilla Chi…
b559d1e 
…na Outposts Missing Detection Sound Effect (#349)
xezon pushed a commit that referenced this pull request Aug 28, 2022
@commy2
Fix: Vanilla China Outposts Missing Detection Effect; Non-Vanilla Chi…
e8f40fd 
…na Outposts Missing Detection Sound Effect (#349)
@xezon xezon added Minor Severity: Minor < Major < Critical < Blocker China Affects China faction labels Mar 18, 2023
@commy2 commy2 mentioned this pull request Aug 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xezon xezon xezon left review comments

@alanblack166 alanblack166 alanblack166 approved these changes

Assignees
No one assigned
Labels
Bug Something is not working right China Affects China faction Minor Severity: Minor < Major < Critical < Blocker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@commy2 @xezon @alanblack166