Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to cheaper texture for BinaryDataStream to potentially cut performance cost #336

Merged
merged 2 commits into from
Apr 22, 2022

Conversation

xezon
Copy link
Collaborator

@xezon xezon commented Sep 12, 2021

Change to cheaper texture for BinaryDataStream to potentially cut performance cost. On my machine I could not observe any performance difference.

Set Patriot stream segment count to 5.
Set Lotus and Hacker segment count to 10.

@xezon xezon requested a review from commy2 September 12, 2021 17:53
@xezon xezon added the Bug Something is not working right label Sep 12, 2021
@commy2 commy2 self-assigned this Sep 12, 2021
@xezon xezon added Enhancement Is new feature or request and removed Bug Something is not working right labels Sep 12, 2021
@xezon
Copy link
Collaborator Author

xezon commented Sep 18, 2021

@commy2
When you have time, can you please test whether or not this change improves performance? You can use

Maps\SkirmishOnly\SkirmishTestPatriotBinaryDataStream

@commy2
Copy link
Collaborator

commy2 commented Sep 18, 2021

Will do.

@xezon xezon added the Performance Is a performance concern label Sep 29, 2021
@xezon
Copy link
Collaborator Author

xezon commented Oct 2, 2021

Increased from 3 to 10 segments for Lotus and Hackers.

shot_20211002_182717_2

@xezon xezon force-pushed the binary-data-stream-improvements branch from c4f1314 to 0e0c6ba Compare April 22, 2022 18:08
@xezon
Copy link
Collaborator Author

xezon commented Apr 22, 2022

Original

shot_20220422_201557_2

Optimized & Refurbished

shot_20220422_202149_1

@xezon xezon force-pushed the binary-data-stream-improvements branch from 0e0c6ba to 53bc672 Compare April 22, 2022 18:31
@xezon xezon merged commit 0b04e9b into main Apr 22, 2022
@xezon xezon deleted the binary-data-stream-improvements branch April 22, 2022 18:33
@commy2 commy2 removed their request for review August 21, 2022 12:07
xezon added a commit that referenced this pull request Aug 28, 2022
@xezon xezon unassigned commy2 Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Is new feature or request Performance Is a performance concern
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants