Fix broken binary stream effect #788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why not provide a copy of EXBinaryStream then? |
|
Could do. Would you prefer that? |
|
I don't know which one is better. We should use the low res one (from CCG), because it is less performance demanding and looks identical for all intends and purposes. I cannot tell you which one that is though. |
|
That would be the one without the 32 then. I will check. |
|
Both textures have the same pixel size and color bits. They look a bit different. The EXBinaryStream.dds texture is present in the Install I had the issue previously. With issue I mean the binary stream was not rendered ingame. Only after switching back to the original EXBinaryStream32.dds it rendered again. I recommend to keep it using the EXBinaryStream32.dds.
|
xezon
added a commit
that referenced
this pull request
Aug 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#336 broke binary effect on some installs.
Appears EXBinaryStream.tga does not exist on CD version. On First Decade it does.