Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Minigunner Has Broken Recoil Animation; Also Tracer Emerges From Below Unit When Aiming At Airborne Targets #312

Merged
merged 2 commits into from
Sep 12, 2021

Conversation

commy2
Copy link
Collaborator

@commy2 commy2 commented Sep 11, 2021

This is three seperate issues really.

ZH 1.04:

  • The Minigunner uses the Red Guards rifle style recoil animation when firing.
  • When firing at airborne targets only, the tracer emerges from the feet of the Minigunner instead his weapon.

After patch:

  • Recoil animation is speed up 4 times, which makes it look pretty good (as far as ZH goes)
  • The tracer emerges from the muzzle, even when aiming at air units.

@commy2 commy2 added the Bug Something is not working right label Sep 11, 2021
@xezon xezon self-requested a review September 11, 2021 20:11
@xezon
Copy link
Collaborator

xezon commented Sep 11, 2021

Could you separate the "When firing at airborne targets only, the Minigunner uses the weapon sound effect of the Gatling Tank instead of his normal effect" from this change? It is unclear if players will prefer the original design, because actually it helps readability if you know the Minigunner is shooting on air units. For example if you play as USA vs Infantry and you hear this sound, then you know your Chinook is likely in danger without even looking. So it is an audio change that actually affects gameplay.

@commy2 commy2 changed the title Fix: Mini-Gunner Has Broken Sound And Fire Animation When Aiming At Airborne Targets Fix: Mini-Gunner Has Broken Recoil Animation; Also Tracer Emerges From Below Unit When Aiming At Airborne Targets Sep 11, 2021
@commy2
Copy link
Collaborator Author

commy2 commented Sep 11, 2021

Removed that part and opened #315 instead. Can talk about it there.

@commy2 commy2 changed the title Fix: Mini-Gunner Has Broken Recoil Animation; Also Tracer Emerges From Below Unit When Aiming At Airborne Targets Fix: Minigunner Has Broken Recoil Animation; Also Tracer Emerges From Below Unit When Aiming At Airborne Targets Sep 11, 2021
@commy2 commy2 merged commit 556e1e5 into main Sep 12, 2021
@commy2 commy2 deleted the fix-minigunner-aa-weapon-effects branch September 12, 2021 06:00
xezon pushed a commit that referenced this pull request Aug 28, 2022
… Below Unit When Aiming At Airborne Targets (#312)
@xezon xezon added Minor Severity: Minor < Major < Critical < Blocker China Affects China faction labels Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is not working right China Affects China faction Minor Severity: Minor < Major < Critical < Blocker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants