Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: Remove second Point Defense Laser from USA King Raptor and halve reload time of single Point Defense Laser #1555

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

xezon
Copy link
Collaborator

@xezon xezon commented Jan 15, 2023

This change removes one PDL (Point Defense Laser) module with a reload time of 266 ms from the USA Airforce King Raptor and halves the reload time of the remaining single PDL module to 133 ms. The overall reload time is the same, but the reduced PDL module count allows for a volley of two rockets instead of three rockets to break through the PDL onto the King Raptor. This is a nerf for Airforce General.

Likewise, the Boss King Raptor now also has the same PDL module with a reload time of 133 ms instead of just one PDL module with a reload time of 266 ms. This is a buff for Boss General.

Rationale

USA Airforce is the best General in the game. Originally, the Airforce King Raptor is very effective in defending against enemy missiles. USA opponents typically struggle to take out King Raptors even with respectable amounts of missiles. With this change it will be a bit easier to combat King Raptors with missiles and take a bit off the edge of Airforce General, without reducing the effectiveness of the King Raptor to engage in typical attacks.

The King Raptor was likely never meant to have 2 PDL modules, which is evident by the small mistake in one of the two PDL modules of the Airforce King Raptor and the Boss King Raptor only owning one PDL module.

@xezon xezon added Design Is a matter of game design Controversial Is controversial Major Severity: Minor < Major < Critical < Blocker Nerf Makes a thing less powerful USA Affects USA faction labels Jan 15, 2023
Copy link
Collaborator

@Stubbjax Stubbjax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For anyone wondering what the implications of this change are, here's a simple demonstration:

RAPS.mp4

If rockets arrive at a uniform rate (1 rocket per 125ms), then the deflection rate remains identical. But if two rockets come in at once (2 rockets per 250ms), then a single PDL cannot immediately take out both, as it has to reload after deflecting the first one.

Essentially, rockets are more effective when grouped together.

@xezon
Copy link
Collaborator Author

xezon commented Jan 16, 2023

That is most beautiful illustration.

@xezon
Copy link
Collaborator Author

xezon commented Jan 16, 2023

250 ms translates to 266 ms, and 125 ms translates to 133 ms.

@ImTimK
Copy link
Collaborator

ImTimK commented Jan 16, 2023

wow sick illustration, looks like a lot of work.

@MTKing4

This comment was marked as off-topic.

@xezon
Copy link
Collaborator Author

xezon commented Feb 4, 2023

This change needs to be tested in match.

@xezon
Copy link
Collaborator Author

xezon commented Feb 11, 2023

Can someone test this in match or test map please?

@MTKing4
Copy link
Collaborator

MTKing4 commented Feb 11, 2023

I'd like to test this with Exile, Air Mirror 1v1, I'll be available tomorrow at evening

@xezon
Copy link
Collaborator Author

xezon commented Feb 20, 2023

This needs testing.

@Stubbjax
Copy link
Collaborator

It'll be pretty hard to tell the difference. The real test will be when the single PDL's DelayBetweenShots is ideally raised to 250 in a future change.

@MTKing4
Copy link
Collaborator

MTKing4 commented Feb 24, 2023

I'd like to assign myself to all the pulls that I need to test later if that's ok, but I'm not sure how to access my assignments later?

@MTKing4 MTKing4 self-assigned this Feb 24, 2023
@xezon
Copy link
Collaborator Author

xezon commented Jun 10, 2023

This needs test.

@xezon xezon force-pushed the balance-pdl-proposal-13 branch from 678eb28 to 4732d60 Compare June 10, 2023 17:26
@xezon
Copy link
Collaborator Author

xezon commented Sep 18, 2023

This will never be tested so we can go ahead without test.

@xezon xezon force-pushed the balance-pdl-proposal-13 branch from 4732d60 to d3fe191 Compare September 18, 2023 15:46
…lve reload time of single Point Defense Laser
@xezon xezon force-pushed the balance-pdl-proposal-13 branch from d3fe191 to 4c03bd2 Compare September 18, 2023 15:49
@xezon xezon added the Boss Affects Boss faction label Sep 18, 2023
@xezon
Copy link
Collaborator Author

xezon commented Sep 18, 2023

Documentation added. Description updated. Rationale text added. Should be good.

@xezon xezon changed the title Point Defense Laser Proposal 13, Remove Secondary PDL From King Raptor and halve PDL Reload Time Change: Remove second Point Defense Laser from USA King Raptor and halve reload time of single Point Defense Laser Sep 18, 2023
@xezon xezon merged commit 0a1d838 into main Sep 18, 2023
@xezon xezon deleted the balance-pdl-proposal-13 branch September 18, 2023 19:37
@ImTimK
Copy link
Collaborator

ImTimK commented Sep 18, 2023

what happens if a raptor targets an enemy raptor?

@xezon
Copy link
Collaborator Author

xezon commented Sep 19, 2023

Probably should decrease severity to Minor.

@ImTimK
Copy link
Collaborator

ImTimK commented Sep 19, 2023

Before all missiles deflected I think, not the case anymore I don't think?

@MTKing4
Copy link
Collaborator

MTKing4 commented Oct 11, 2023

I understand that taking too long to get tests going is getting in the way, but i do feel like that it's highly necessary to test changes like this to have a stronger rationale that people can read and understand, and will also give is more insight, also i think it would help us a lot to not lose these untested changes with all the other changes.

The problem is i couldn't find anyone to test with at the time, and now I can't anymore as I'm too busy, and I'll be away for several weeks from now at the very least, but when i do get back:

I'd like to keep myself assigned for now, and restore the Branch later for testing when i can test, then remove it again.

@xezon
Copy link
Collaborator Author

xezon commented Oct 11, 2023

The change is in main branch. It can be tested in main branch.

@MTKing4
Copy link
Collaborator

MTKing4 commented Oct 11, 2023

I know, but i will probably lose track of this and forget to test this, i usually keep track of my tests on my assignments

@MTKing4 MTKing4 self-assigned this Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Boss Affects Boss faction Controversial Is controversial Design Is a matter of game design Major Severity: Minor < Major < Critical < Blocker Nerf Makes a thing less powerful USA Affects USA faction
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants