-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Spawn SCUD Storm Hole Worker after Toxin Puddle disappears - after 30 seconds instead of 20 seconds #1096
Conversation
Exile:
Jundiyy:
|
Why would the Worker come up for the Scud Storm later than for other buildings though? This change breaks consistency all for a super minor balance thing that essentially never comes into play. |
The Worker comes after the Toxin Puddle clears. If he comes before that, he dies. I do not think the consistency argument is a strong argument. Logically Worker waits until Toxin Puddle is gone, so it is ok if it takes longer than other buildings. Other buildings do not spawn a Toxin Puddle. If we would change Toxin Puddle from 30 seconds to 20 seconds, then that would require new Toxin Puddle setup and we would introduce inconsistent Puddle Times. |
54fb1d3
to
caf13c1
Compare
I optimized timings. Worker now spawns in 30000 ms instead of 30100 ms, and the Toxin Field timings are individually tweaked for Scud Storm to accommodate first spawning Worker. Video attached. |
caf13c1
to
02f40f5
Compare
Someone shall Approve this, then I will merge. Jundiyy, Exile and I are in favor of this. commy2 not in favor, because of hole worker spawn time inconsistency. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The technical aspects work.
Is it 30s for all buildings though? |
For all Scud Storms. |
This change spawns the SCUD Storm Hole worker in 30 seconds instead of 20 seconds intervals. This will prevent the first worker from dying in the poison. No EVA event is triggered for damaging the spawned worker. Effectively a SCUD Storm can rebuild 10 seconds quicker than originally. The Toxin Field time has been adjusted to accommodate the Worker spawn time properly.
Note: It is not possible to use an external worker to continue repair a GLA building from GLA hole. Therefore the reduction in Toxin Field time is practically inconsequential.
This proposal was originally discussed in:
Original
Worker spawns in the Toxin and dies.
Patched
Worker spawns just as the Toxin disappears.
scud_storm_worker.mp4