Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix shell identification #544

Merged
merged 3 commits into from
Apr 23, 2024
Merged

Fix shell identification #544

merged 3 commits into from
Apr 23, 2024

Conversation

counterapparatus
Copy link
Contributor

fixed bug where sgpt --install-integration fails for people who have bash or zsh in /usr/bin/ by using "zsh" in shell

This fixes #492 and #528

@TheR1D TheR1D linked an issue Apr 23, 2024 that may be closed by this pull request
sgp --install-integration fails to detect zsh #528
Closed
TheR1D
TheR1D approved these changes Apr 23, 2024
View reviewed changes
Copy link
Owner

@TheR1D TheR1D left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@TheR1D TheR1D merged commit 20405b2 into TheR1D:main Apr 23, 2024
3 checks passed
@danjeltahko danjeltahko mentioned this pull request Jul 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheR1D TheR1D TheR1D approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sgp --install-integration fails to detect zsh Error: ShellGPT integrations only available for ZSH and Bash.
3 participants
@counterapparatus @TheR1D @SamLawAnthro