Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sgp --install-integration fails to detect zsh #528

Closed
AskAlice opened this issue Apr 1, 2024 · 0 comments · Fixed by #544
Closed

sgp --install-integration fails to detect zsh #528

AskAlice opened this issue Apr 1, 2024 · 0 comments · Fixed by #544

Comments

@AskAlice
Copy link

AskAlice commented Apr 1, 2024 •
edited
Loading

perhaps instead of checking if /bin/zsh or /bin/bash is the $SHELL, perhaps check if
$SHELL === $(which zsh) || $(which bash) as my zsh is at /usr/bin/zsh on arch linux

or just .find("bash") / .find("zsh") on the shell var
@counterapparatus counterapparatus mentioned this issue Apr 15, 2024
Merged
@TheR1D TheR1D linked a pull request Apr 23, 2024 that will close this issue
Fix shell identification #544
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix shell identification counterapparatus/shell_gpt
1 participant
@AskAlice