Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add Ruby Project Management and Linting lessons #4540

Conversation

scheals
Copy link
Contributor

@scheals scheals commented May 23, 2024

Because

It'd be cool to have those lessons.

This PR

  • Adds those lessons so they actually show up in the curriculum!

Issue

Related:

Additional Information

Please merge these first:

Also, for all the poor WSL2 souls that have failing rspec tests:
Do not follow Cliver error output. It won't be happy with a wslpath'd Chrome on Windows side. At least, it wasn't in my case. Just install Chrome in WSL2 and it'll be happy.

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this PR follows the keyword: brief description of change format, using one of the following keywords:
    • Feature - adds new or amends existing user-facing behavior
    • Chore - changes that have no user-facing value, refactors, dependency bumps, etc
    • Fix - bug fixes
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • I have verified all tests and linters pass after making these changes.
  • If this PR addresses an open issue, it is linked in the Issue section
  • If applicable, this PR includes new or updated automated tests

@scheals
Copy link
Contributor Author

scheals commented May 23, 2024

@JoshDevHub All systems set! (well, besides the two PRs that need to come in before this one :))

Copy link
Contributor

@JoshDevHub JoshDevHub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful stuff. Thank you for working on these lessons @scheals 🙌

@JoshDevHub JoshDevHub merged commit c527256 into TheOdinProject:main May 24, 2024
3 checks passed
@scheals scheals deleted the feat/add_project_management_and_linting branch May 24, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants