Ruby: Linting and RuboCop: Add statically links to images #28040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JoshDevHub Images locked and loaded! |
7 tasks
JoshDevHub
approved these changes
May 23, 2024
JoshDevHub
pushed a commit
to TheOdinProject/theodinproject
that referenced
this pull request
May 24, 2024
## Because It'd be cool to have those lessons. ## This PR - Adds those lessons so they actually show up in the curriculum! ## Issue Related: - TheOdinProject/curriculum#27026 - TheOdinProject/curriculum#27091 ## Additional Information Please merge these first: - TheOdinProject/curriculum#28040 - TheOdinProject/curriculum#28041 Also, for all the poor WSL2 souls that have failing rspec tests: Do not follow Cliver error output. It won't be happy with a wslpath'd Chrome on Windows side. At least, it wasn't in my case. Just install Chrome in WSL2 and it'll be happy. ## Pull Request Requirements - [x] I have thoroughly read and understand [The Odin Project Contributing Guide](https://github.com/TheOdinProject/theodinproject/blob/main/CONTRIBUTING.md) - [x] The title of this PR follows the `keyword: brief description of change` format, using one of the following keywords: - `Feature` - adds new or amends existing user-facing behavior - `Chore` - changes that have no user-facing value, refactors, dependency bumps, etc - `Fix` - bug fixes - [x] The `Because` section summarizes the reason for this PR - [x] The `This PR` section has a bullet point list describing the changes in this PR - [x] I have verified all tests and linters pass after making these changes. - [x] If this PR addresses an open issue, it is linked in the `Issue` section - [ ] If applicable, this PR includes new or updated automated tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
We want the images to be served from statically.
This PR
Issue
Related: #27091
Additional Information
Pull Request Requirements
location of change: brief description of changeformat, e.g.Intro to HTML and CSS lesson: Fix link textBecausesection summarizes the reason for this PRThis PRsection has a bullet point list describing the changes in this PRIssuesection