Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates GameMath version used. #870

Merged
merged 1 commit into from
Feb 23, 2023

Conversation

OmniBlade
Copy link
Contributor

@OmniBlade OmniBlade commented Feb 21, 2023

GameMath has been updated to make use of CPU instructions in some functions.

@codecov-commenter
Copy link

codecov-commenter commented Feb 21, 2023

Codecov Report

Base: 3.35% // Head: 3.35% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (62120ba) compared to base (ad16c1f).
Patch coverage: 0.00% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           develop    #870      +/-   ##
==========================================
- Coverage     3.35%   3.35%   -0.01%     
==========================================
  Files          750     753       +3     
  Lines        71048   71082      +34     
  Branches     11577   11580       +3     
==========================================
  Hits          2382    2382              
- Misses       68322   68356      +34     
  Partials       344     344              
Impacted Files Coverage Δ
src/game/common/rts/academystats.cpp 0.00% <0.00%> (ø)
src/game/common/rts/academystats.h 0.00% <0.00%> (ø)
src/game/common/rts/money.cpp 0.00% <0.00%> (ø)
src/game/common/rts/money.h 0.00% <ø> (ø)
src/game/common/rts/player.h 0.00% <ø> (ø)
src/game/common/system/cdmanager.cpp 0.00% <0.00%> (ø)
src/game/common/system/cdmanager.h 0.00% <0.00%> (ø)
src/game/logic/object/update/aiupdate.cpp 0.00% <0.00%> (ø)
src/w3d/lib/cpudetect.cpp 21.17% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@feliwir
Copy link
Contributor

feliwir commented Feb 21, 2023

Could be maybe merge #867 before, so we can see the perf change?

Copy link
Contributor

@jonwil jonwil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me.

@xezon
Copy link
Contributor

xezon commented Feb 21, 2023

Related change: TheAssemblyArmada/GameMath@4d2d815

Copy link
Contributor

@xezon xezon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in RelWithDebInfo. Works. Performance is through the roof. On my machine it now runs with 300 FPS where it ran with 50 FPS prior this fix.

Fixes #864.

GameMath has been updated to make use of CPU instructions in some
functions.
@xezon xezon merged commit bb1e49c into TheAssemblyArmada:develop Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need to add fast math functions
6 participants