Avoid stlport compile error with Visual Studio 2022 #1116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #1116 +/- ##
========================================
Coverage 2.53% 2.53%
========================================
Files 949 949
Lines 110299 110299
Branches 18881 18881
========================================
Hits 2800 2800
Misses 107095 107095
Partials 404 404 ☔ View full report in Codecov by Sentry. |
xezon
force-pushed
the
fix-vs2022-compilation
branch
from
e73262a to
8c89a10
Compare
OmniBlade
approved these changes
Feb 14, 2024
|
Yes if some platform needs this explicitly then we compile it in for just that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change
fixesavoids stlport compile error with Visual Studio 2022.xstddeffile does not exist in Visual Studio 2022. It does exist in Visual Studio 2019 however. But Visual Studio 2019 also compiles withoutxstddefincluded inexceptionfrom stlport.Unclear what is going on.
This include was already touched prior with 9d9908f