Make devtools deps extras, add note to internal ref docs, raise excep… #579
Conversation
| @@ -25,7 +25,7 @@ jobs: | |||
| version: 1.1.6 | |||
| virtualenvs-in-project: true | |||
| - name: Install dependencies | |||
| run: poetry install | |||
| run: poetry install --extras "dev" | |||
There was a problem hiding this comment.
| msgpack = "^1.0.3" | ||
|
|
||
| # Dependencies below are required for devtools only | ||
| aiohttp = { version = "^3.8.1", optional = true } |
There was a problem hiding this comment.
@willmcgugan Do we move click into the dev extras too?
There was a problem hiding this comment.
I think so. Is it possible to install the textual command only with dev extras?
There was a problem hiding this comment.
I'm not sure I understand the question, but I don't believe you can install only the extras.
There was a problem hiding this comment.
We should only install the textual CLI when you pip install textual[dev]. Because we don't need it just to distribute apps. Is that possible?
There was a problem hiding this comment.
I don't believe so. Think we'd have to distribute the devtools as a separate package.
| @@ -0,0 +1,12 @@ | |||
| # Devtools | |||
There was a problem hiding this comment.
These are more just notes to remind us what to include in the docs when the structure is in place. They're not the final docs.
#579) * Make devtools deps extras, add note to internal ref docs, raise exception when deps missing * Ensure dev extras are installed in GitHub Actions * Update lockfile * Add extra docs note * Add a TODO about adding link to devtools docs * Add click to dev extras dependencies in pyproject
…tion when deps missing