Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev dependencies #403

Closed
willmcgugan opened this issue Apr 19, 2022 · 2 comments · Fixed by #579
Closed

Dev dependencies #403

willmcgugan opened this issue Apr 19, 2022 · 2 comments · Fixed by #579
Assignees
@darrenburns

Comments

@willmcgugan
Copy link
Collaborator

I think the new devtools feature introduces a dependancy on aiohttp. This would only be needed for developing Textual apps, not for using them.

Suggest we add aiohttp as a dev requirement, and make it option when importing. So to develop Textual apps you would do pip install textual[dev]

If the user requests devtools with TEXTUAL_DEVTOOLS=1 and aiohttp is not installed, I think we should probably exit with an error.
@darrenburns
Copy link
Member

Good point

@darrenburns darrenburns linked a pull request Jun 15, 2022 that will close this issue
Make devtools deps extras, add note to internal ref docs, raise excep… #579
Merged
@github-actions
Copy link

Did we solve your problem?

Consider buying the Textualize developers a coffee to say thanks.

– Textualize

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@darrenburns darrenburns

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make devtools deps extras, add note to internal ref docs, raise excep… Textualize/textual
2 participants
@willmcgugan @darrenburns