Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delay suggestions until an Input is modified #4335

Merged
merged 5 commits into from
Mar 26, 2024
Merged

Delay suggestions until an Input is modified #4335

merged 5 commits into from
Mar 26, 2024

Conversation

davep
Copy link
Contributor

@davep davep commented Mar 25, 2024

Fixes #3811.

@davep davep added enhancement New feature or request Task labels Mar 25, 2024
@davep davep self-assigned this Mar 25, 2024
@davep davep marked this pull request as ready for review March 26, 2024 08:42
davep added a commit to davep/textual-sandbox that referenced this pull request Mar 26, 2024
@davep
✨ Add a tester for Textualize/textual#4335
8d79b2e
rodrigogiraoserrao
rodrigogiraoserrao approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@rodrigogiraoserrao rodrigogiraoserrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable to me 🤷

@davep davep merged commit 482cf24 into Textualize:main Mar 26, 2024
20 checks passed
@davep davep deleted the less-busy-suggest branch March 26, 2024 10:48
@renovate renovate bot mentioned this pull request Oct 28, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodrigogiraoserrao rodrigogiraoserrao rodrigogiraoserrao approved these changes

@willmcgugan willmcgugan Awaiting requested review from willmcgugan

@darrenburns darrenburns Awaiting requested review from darrenburns

Assignees

@davep davep

Labels
enhancement New feature or request Task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The Input suggester should only show suggestions if an active edit is happening
2 participants
@davep @rodrigogiraoserrao