Skip to content

Commit

Permalink
Merge pull request #4335 from davep/less-busy-suggest
Browse files Browse the repository at this point in the history
Delay suggestions until an `Input` is modified
  • Loading branch information
davep authored Mar 26, 2024
2 parents 459e356 + a68698d commit 482cf24
Show file tree
Hide file tree
Showing 4 changed files with 65 additions and 63 deletions.
3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
- Fixed issue where narrow TextArea would repeatedly wrap due to scrollbar appearing/disappearing https://github.com/Textualize/textual/pull/4334
- Fix progress bar ETA not updating when setting `total` reactive https://github.com/Textualize/textual/pull/4316

### Changed
### Changed

- ProgressBar won't show ETA until there is at least one second of samples https://github.com/Textualize/textual/pull/4316
- `Input` waits until an edit has been made, after entry to the widget, before offering a suggestion https://github.com/Textualize/textual/pull/4335

## [0.53.1] - 2023-03-18

Expand Down
1 change: 1 addition & 0 deletions src/textual/widgets/_input.py
Original file line number Diff line number Diff line change
Expand Up @@ -519,6 +519,7 @@ def _on_focus(self, _: Focus) -> None:
if self.cursor_blink:
self._blink_timer.resume()
self.app.cursor_position = self.cursor_screen_offset
self._suggestion = ""

async def _on_key(self, event: events.Key) -> None:
self._cursor_visible = True
Expand Down
Loading

0 comments on commit 482cf24

Please sign in to comment.