Add title and sub-title to screens. #3199
Conversation
Mimicking 'App', we provide class variables TITLE and SUB_TITLE for the screen defaults and those can then be changed via the title and sub_title reactive attributes. Related issue: #3195
src/textual/screen.py
Outdated
| @@ -128,10 +129,31 @@ class Screen(Generic[ScreenResultType], Widget): | |||
| background: $surface; | |||
| } | |||
| """ | |||
|
|
|||
| TITLE: str | None = None | |||
There was a problem hiding this comment.
These should be typed as ClassVar
There was a problem hiding this comment.
See 5ec3fea.
src/textual/widgets/_header.py
Outdated
| @@ -161,11 +161,19 @@ def _on_click(self): | |||
| self.toggle_class("-tall") | |||
|
|
|||
| def _on_mount(self, _: Mount) -> None: | |||
| def set_title(title: str) -> None: | |||
| def set_title() -> None: | |||
| screen_title = self.screen.title | |||
There was a problem hiding this comment.
We should have a more elegant way of exposing the actual title. So that a developer doesn't need to replicate this logic.
Perhaps a computed value called screen_title and screen_subtitle
There was a problem hiding this comment.
See 4ed93d4
| @@ -160,12 +160,28 @@ def watch_tall(self, tall: bool) -> None: | |||
| def _on_click(self): | |||
| self.toggle_class("-tall") | |||
|
|
|||
| @property | |||
| def screen_title(self) -> str: | |||
There was a problem hiding this comment.
Docstrings pls.
Could we make these computed reactives? That way you could watch self.screen_title
There was a problem hiding this comment.
See 5a15e9c for docstrings.
As per our conversation, we can't make them computed reactives because we can't trigger the compute method when the reactives on Screen or App change.
Related comment: #3199 (comment)
Mimicking 'App', we provide class variables TITLE and SUB_TITLE for the screen defaults and those can then be changed via the title and sub_title reactive attributes.
Related issue: #3195