Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Screens should have a title and subtitle #3195

Closed
MartijnBraam opened this issue Aug 28, 2023 · 2 comments · Fixed by #3199
Closed

Screens should have a title and subtitle #3195

MartijnBraam opened this issue Aug 28, 2023 · 2 comments · Fixed by #3199
Assignees
@rodrigogiraoserrao
Labels
Task

Comments

@MartijnBraam
Copy link

When implementing a multi-screen application that has Header widgets in the screens the title and subtitle displayed in the Header should be stored in the Screen as overrides instead of only using the global values from the application.

This would simplify displaying titles in screens properly with keeping the title and subtitle synchronized with the screen stack.
@willmcgugan
Copy link
Collaborator

Should be easy to implement. Screen would have title and subtitle, which would override the App attributes if not None. We would need to manage titles when the active screen changes.

@Textualize Textualize deleted a comment from github-actions bot Aug 28, 2023
@rodrigogiraoserrao rodrigogiraoserrao self-assigned this Aug 28, 2023
rodrigogiraoserrao added a commit that referenced this issue Aug 29, 2023
@rodrigogiraoserrao
Add title and sub-title to screens.
e48e014 
Mimicking 'App', we provide class variables TITLE and SUB_TITLE for the screen defaults and those can then be changed via the title and sub_title reactive attributes.

Related issue: #3195
@rodrigogiraoserrao rodrigogiraoserrao mentioned this issue Aug 29, 2023
Merged
@rodrigogiraoserrao rodrigogiraoserrao linked a pull request Aug 29, 2023 that will close this issue
Add title and sub-title to screens. #3199
Merged
@github-actions
Copy link

Don't forget to star the repository!

Follow @textualizeio for Textual updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rodrigogiraoserrao rodrigogiraoserrao

Labels
Task
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add title and sub-title to screens. Textualize/textual
3 participants
@willmcgugan @rodrigogiraoserrao @MartijnBraam