Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete Reactive.var. #2709

Merged
merged 2 commits into from
Jun 6, 2023
Merged

Delete Reactive.var. #2709

merged 2 commits into from
Jun 6, 2023

Conversation

rodrigogiraoserrao
Copy link
Contributor

@rodrigogiraoserrao rodrigogiraoserrao commented May 31, 2023 •
edited
Loading

Closes #2706.

Deletes Reactive.var in favour of var.

@rodrigogiraoserrao
Delete Reactive.var.
8516dda 
Related issues: #2706.
@rodrigogiraoserrao rodrigogiraoserrao self-assigned this May 31, 2023
davep
davep approved these changes Jun 5, 2023
View reviewed changes
Copy link
Contributor

@davep davep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming this isn't ever used anywhere, makes sense to me. It's worth noting too that it never passed on always_update.

I'd be tempted to mark this in the CHANGELOG as a breaking change though given it's removing something.

@rodrigogiraoserrao
Copy link
Contributor Author

I'd be tempted to mark this in the CHANGELOG as a breaking change though given it's removing something.

Aren't all deletions breaking changes by default?

@davep
Copy link
Contributor

davep commented Jun 5, 2023

Sure, but I feel it makes it stand out and easier to search for - would also fit in with other entries marked this way.

@rodrigogiraoserrao
Copy link
Contributor Author

Sure, but I feel it makes it stand out and easier to search for - would also fit in with other entries marked this way.

Thanks for the suggestion! Done.

@rodrigogiraoserrao rodrigogiraoserrao merged commit f0871ad into main Jun 6, 2023
@rodrigogiraoserrao rodrigogiraoserrao deleted the delete-reactive-var branch June 6, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willmcgugan willmcgugan willmcgugan approved these changes

@davep davep davep approved these changes

Assignees

@rodrigogiraoserrao rodrigogiraoserrao

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Reactive.var in favour of var?
3 participants
@rodrigogiraoserrao @davep @willmcgugan