Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Reactive.var in favour of var? #2706

Closed
rodrigogiraoserrao opened this issue May 31, 2023 · 1 comment · Fixed by #2709
Closed

Remove Reactive.var in favour of var? #2706

rodrigogiraoserrao opened this issue May 31, 2023 · 1 comment · Fixed by #2709
Assignees
@rodrigogiraoserrao
Labels
question Further information is requested

Comments

@rodrigogiraoserrao
Copy link
Contributor

rodrigogiraoserrao commented May 31, 2023 •
edited
Loading

In reactive.py we have the classmethod Reactive.var and the class var that subclasses Reactive.
They are not strictly equivalent, but they seem to have the same purpose.
Should we delete Reactive.var?
@rodrigogiraoserrao rodrigogiraoserrao added the question Further information is requested label May 31, 2023
rodrigogiraoserrao added a commit that referenced this issue May 31, 2023
@rodrigogiraoserrao
Delete Reactive.var.
8516dda 
Related issues: #2706.
@rodrigogiraoserrao rodrigogiraoserrao mentioned this issue May 31, 2023
Merged
@rodrigogiraoserrao rodrigogiraoserrao self-assigned this May 31, 2023
@github-actions
Copy link

github-actions bot commented Jun 6, 2023

Don't forget to star the repository!

Follow @textualizeio for Textual updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rodrigogiraoserrao rodrigogiraoserrao

Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Delete Reactive.var. Textualize/textual
1 participant
@rodrigogiraoserrao