Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Private validate compute #2708

Merged
merged 11 commits into from
Jun 6, 2023
Merged

Private validate compute #2708

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
1c7cb06
Activate private validate method test.
rodrigogiraoserrao May 30, 2023
648d5f4
Use private validate methods.
rodrigogiraoserrao May 30, 2023
85722d6
Test private validate methods.
rodrigogiraoserrao May 31, 2023
41af804
Check for private AND public compute methods.
rodrigogiraoserrao May 31, 2023
fdc7ba3
Add tests for private computes.
rodrigogiraoserrao May 31, 2023
2293f40
Use private computes.
rodrigogiraoserrao May 31, 2023
73019fa
Fix name shadowing issue.
rodrigogiraoserrao May 31, 2023
b1a6954
Changelog.
rodrigogiraoserrao May 31, 2023
e170bbe
Merge branch 'main' into private-validate-compute
rodrigogiraoserrao May 31, 2023
2057c46
Extract prefix (length).
rodrigogiraoserrao Jun 5, 2023
a26b0fd
Update src/textual/message_pump.py
rodrigogiraoserrao Jun 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/textual/message_pump.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,9 +76,11 @@ def __new__(
)

# Look for reactives with public AND private compute methods.
prefix = "compute_"
prefix_len = len("compute_")
rodrigogiraoserrao marked this conversation as resolved.
Show resolved Hide resolved
for attr_name, value in class_dict.items():
if attr_name.startswith("compute_") and callable(value):
reactive_name = attr_name[len("compute_") :]
if attr_name.startswith(prefix) and callable(value):
reactive_name = attr_name[prefix_len:]
if (
reactive_name in class_dict
and isinstance(class_dict[reactive_name], Reactive)
Expand Down