Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Private validate compute #2708

Merged
merged 11 commits into from
Jun 6, 2023
Merged

Private validate compute #2708

merged 11 commits into from
Jun 6, 2023

Conversation

rodrigogiraoserrao
Copy link
Contributor

@rodrigogiraoserrao rodrigogiraoserrao commented May 31, 2023 •
edited
Loading

Closes #2539.

  • Adds ability to have private validate methods along with public ones.
  • If there are public and private validate methods, the private one runs first.
  • Adds ability to have private compute methods.
  • If there are public and private compute methods, the error TooManyComputesError is raised.

Right now, there is no documentation about private watch/validate/compute methods.
Only docstrings.

Related PRs: #2442
Related issues: #2382

@rodrigogiraoserrao
Activate private validate method test.
1c7cb06
@rodrigogiraoserrao
Use private validate methods.
648d5f4 
Private validate methods are checked before the public ones.
@rodrigogiraoserrao
Test private validate methods.
85722d6
@rodrigogiraoserrao
Check for private AND public compute methods.
41af804 
We do this inside _MessagePumpMeta.__new__ because this runs at 'import time', and thus is essentially the earliest we can figure out if this is not going to work.
@rodrigogiraoserrao
Add tests for private computes.
fdc7ba3
@rodrigogiraoserrao
Use private computes.
2293f40
@rodrigogiraoserrao
Fix name shadowing issue.
73019fa
@rodrigogiraoserrao
Changelog.
b1a6954
@rodrigogiraoserrao
Merge branch 'main' into private-validate-compute
e170bbe
@rodrigogiraoserrao rodrigogiraoserrao self-assigned this May 31, 2023
@rodrigogiraoserrao rodrigogiraoserrao added enhancement New feature or request Task labels May 31, 2023
davep
davep approved these changes Jun 5, 2023
View reviewed changes
Copy link
Contributor

@davep davep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. One very minor suggestion.

src/textual/message_pump.py Outdated Show resolved Hide resolved
davep
davep reviewed Jun 5, 2023
View reviewed changes
src/textual/message_pump.py Outdated Show resolved Hide resolved
@davep davep mentioned this pull request Jun 6, 2023
Merged
@rodrigogiraoserrao rodrigogiraoserrao merged commit 0d646dd into main Jun 6, 2023
@rodrigogiraoserrao rodrigogiraoserrao deleted the private-validate-compute branch June 6, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davep davep davep approved these changes

@willmcgugan willmcgugan willmcgugan approved these changes

@darrenburns darrenburns Awaiting requested review from darrenburns

Assignees

@rodrigogiraoserrao rodrigogiraoserrao

Labels
enhancement New feature or request Task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow private validate and compute methods
3 participants
@rodrigogiraoserrao @davep @willmcgugan