Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Splitting out parsing of durations into new token types, avoiding Scalar #214

Merged
merged 10 commits into from
Jan 19, 2022
Merged

Splitting out parsing of durations into new token types, avoiding Scalar #214

merged 10 commits into from
Jan 19, 2022

Conversation

darrenburns
Copy link
Member

No description provided.

@darrenburns darrenburns marked this pull request as draft January 18, 2022 17:36
@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (css@d7bcd00). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##             css     #214   +/-   ##
======================================
  Coverage       ?   29.46%           
======================================
  Files          ?       80           
  Lines          ?     6184           
  Branches       ?        0           
======================================
  Hits           ?     1822           
  Misses         ?     4362           
  Partials       ?        0
Flag Coverage Δ
unittests 29.46% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7bcd00...c462beb. Read the comment docs.

@darrenburns darrenburns marked this pull request as ready for review January 19, 2022 15:22
@darrenburns darrenburns linked an issue Jan 19, 2022 that may be closed by this pull request
Extract time values from CSS #203
Closed
willmcgugan
willmcgugan requested changes Jan 19, 2022
View reviewed changes
Copy link
Collaborator

@willmcgugan willmcgugan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Just some pedantic requests.

src/textual/_duration.py Outdated Show resolved Hide resolved
src/textual/_duration.py Outdated Show resolved Hide resolved
src/textual/_duration.py Outdated Show resolved Hide resolved
src/textual/css/_styles_builder.py Show resolved Hide resolved
src/textual/css/stylesheet.py Outdated Show resolved Hide resolved
willmcgugan
willmcgugan approved these changes Jan 19, 2022
View reviewed changes
Copy link
Collaborator

@willmcgugan willmcgugan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@willmcgugan willmcgugan merged commit 185788b into css Jan 19, 2022
@willmcgugan willmcgugan deleted the time-no-scalar branch January 19, 2022 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willmcgugan willmcgugan willmcgugan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extract time values from CSS
3 participants
@darrenburns @codecov-commenter @willmcgugan