Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract time values from CSS #203

Closed
willmcgugan opened this issue Jan 13, 2022 · 1 comment · Fixed by #214
Closed

Extract time values from CSS #203

willmcgugan opened this issue Jan 13, 2022 · 1 comment · Fixed by #214
Assignees

Comments

@willmcgugan
Copy link
Collaborator

Values for time in transition rule (and potentially elsewhere) are parsed in to a Scalar object.

Time is technically a scalar, but it adds a bit of confusion to the Scalar class which is mostly used for dimensions.

We should drop the use of Scalar for time and define another object to store the times. Perhaps an object for time is overkill, and we should simply use a float for seconds.

Ask WM for a tour of how CSS is parsed in Textual before attempting this one.

@github-actions
Copy link

Did I solve your problem?

Consider sponsoring my work on Textual with a monthly donation.

Or buy me a coffee to say thanks.

Will McGugan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants