Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow by-code scrolling even when by-input scrolling would be denied #1550

Merged
merged 10 commits into from
Jan 16, 2023
Merged

Allow by-code scrolling even when by-input scrolling would be denied #1550

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
f44d483
Always refresh a changed scroll value, even if there's no scrollbar
davep Jan 12, 2023
7cc17d6
Have scroll_x/y watch functions obey relevant allow properties
davep Jan 12, 2023
9fee634
Add a new force parameter to all the scroll_ methods
davep Jan 12, 2023
5dbecdd
Merge branch 'main' into issue/1201/scroll-to-with-code
davep Jan 12, 2023
13e68b6
Tidy up the force parameter in all the docstrings
davep Jan 12, 2023
8b3608e
Merge branch 'issue/1201/scroll-to-with-code' of github.com:davep/tex…
davep Jan 15, 2023
843810e
Remove no-scroll guard from scroll watchers
davep Jan 15, 2023
1b9f51a
Merge branch 'main' into issue/1201/scroll-to-with-code
davep Jan 15, 2023
2b2d6c7
Correct over-eager remove of if constructs
davep Jan 16, 2023
6c64773
Merge branch 'main' into issue/1201/scroll-to-with-code
davep Jan 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
- Added Widget._refresh_scroll to avoid expensive layout when scrolling https://github.com/Textualize/textual/pull/1524
- `events.Paste` now bubbles https://github.com/Textualize/textual/issues/1434
- Clock color in the `Header` widget now matches the header color https://github.com/Textualize/textual/issues/1459
- Programmatic calls to scroll now optionally scroll even if overflow styling says otherwise (introduces a new `force` parameter to all the `scroll_*` methods) https://github.com/Textualize/textual/issues/1201
- Watch methods may now take no parameters
- Added `compute` parameter to reactive

Expand Down
Loading