Allow by-code scrolling even when by-input scrolling would be denied #1550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See Textualize#1201. See Textualize#1201 (comment) though -- there has been internal discussion about how there may be a need to even inhibit by-code scrolling (as opposed to by-input) scrolling, in some situations. This would likely require that there's something higher-level, perhaps, that doesn't even attempt to animate `scroll_x` or `scroll_y` in the first place. Consider this a placeholder approach for the moment.
davep
requested review from
darrenburns,
willmcgugan and
rodrigogiraoserrao
and removed request for
darrenburns and
willmcgugan
rodrigogiraoserrao
suggested changes
Jan 12, 2023
|
Doh! Good catch on the spaces. I'll tweak them in one go. |
willmcgugan
reviewed
Jan 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1201.
See
#1201 (comment) though.