Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Radioset should focus as a single widget, and use cursor keys to navigate options #2368

Closed
davep opened this issue Apr 25, 2023 · 1 comment · Fixed by #2372
Closed

Radioset should focus as a single widget, and use cursor keys to navigate options #2368

davep opened this issue Apr 25, 2023 · 1 comment · Fixed by #2372
Assignees
Labels
enhancement New feature or request Task

Comments

@davep
Copy link
Contributor

davep commented Apr 25, 2023

The RadioSet has worked well so far, and now it's time to extend it somewhat so it plays with the other widgets more like it's a "standalone" widget rather than a container of widgets.

@davep davep self-assigned this Apr 25, 2023
@davep davep added enhancement New feature or request Task labels Apr 25, 2023
davep added a commit to davep/textual that referenced this issue Apr 25, 2023
With this commit a RadioSet becomes something you can tab into and out of
with just one keypress; navigation of the buttons within moves to being done
with the cursor keys instead.

See Textualize#2368.
davep added a commit to davep/textual that referenced this issue Apr 25, 2023
Initially we went with a RadioSet being a simple container of RadioButtons,
with the user navigating the RadioButtons like you would any other set of
widgets. This was fine but it became pretty clear pretty quickly that having
to tab through a non-trivial collection of buttons in a set to get to the
next widget wasn't ideal.

This commit, satisfying Textualize#2368, takes over the navigation of the buttons
within the container, makes the container itself a focusable widget, and
sets up some new bindings to allow a more natural and efficient interaction
with the set.
@davep davep linked a pull request Apr 25, 2023 that will close this issue
@github-actions
Copy link

Don't forget to star the repository!

Follow @textualizeio for Textual updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Task
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant