Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text wrapping edgecase #2296

Merged
merged 18 commits into from
May 27, 2022
Merged

Text wrapping edgecase #2296

merged 18 commits into from
May 27, 2022

Conversation

darrenburns
Copy link
Member

@darrenburns darrenburns commented May 25, 2022

Type of changes

  • Bug fix
  • New feature
  • Documentation / docstrings
  • Tests
  • Other

Checklist

  • I've run the latest black with default args on new code.
  • I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate.
  • I've added tests for new code.
  • I accept that @willmcgugan may be pedantic in the code review.

Description

Fixes #2273

@darrenburns darrenburns marked this pull request as ready for review May 25, 2022 12:47
@darrenburns darrenburns requested review from willmcgugan and olivierphi and removed request for olivierphi May 25, 2022 12:51
Copy link

@olivierphi olivierphi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! 🕵️

@darrenburns
Copy link
Member Author

I've managed to write a failing test for this :)

@darrenburns darrenburns removed the request for review from willmcgugan May 25, 2022 14:12
@darrenburns darrenburns marked this pull request as draft May 25, 2022 14:17
@darrenburns darrenburns marked this pull request as ready for review May 25, 2022 15:28
rich/cells.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@willmcgugan willmcgugan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #2296 (0dc3985) into master (14d47c9) will decrease coverage by 0.08%.
The diff coverage is 96.72%.

@@            Coverage Diff             @@
##           master    #2296      +/-   ##
==========================================
- Coverage   98.88%   98.80%   -0.09%     
==========================================
  Files          73       73              
  Lines        7629     7674      +45     
==========================================
+ Hits         7544     7582      +38     
- Misses         85       92       +7     
Flag Coverage Δ
unittests 98.80% <96.72%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rich/_export_format.py 100.00% <ø> (ø)
rich/cells.py 100.00% <ø> (ø)
rich/console.py 98.29% <96.03%> (-0.49%) ⬇️
rich/_wrap.py 100.00% <100.00%> (ø)
rich/syntax.py 99.30% <100.00%> (+0.02%) ⬆️
rich/terminal_theme.py 100.00% <100.00%> (ø)
rich/traceback.py 98.68% <0.00%> (-0.88%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa7926c...0dc3985. Read the comment docs.

@willmcgugan willmcgugan merged commit 2be0fc9 into master May 27, 2022
@willmcgugan willmcgugan deleted the text-wrapping-edgecase branch May 27, 2022 15:14
@willmcgugan
Copy link
Collaborator

The system failed for this PR. I'm pretty I merged a failing test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Text wrapping edge case
4 participants