refactor: remove deprecated method #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jack Cherng <[email protected]>
|
The test fail from flake8 looks like a false positive to me. They are used with Okay. This is embarrassing as latest flake8 v6 uses pyflakes v3 and pyflakes v3 requires python>=3.6 so they ask user to use annotation now. PyCQA/pyflakes#747 I think we have to pin a previous flake8 now unless we use python 3.8 in the future. |
Because flake8 v6, which uses pyflakes v3, removes support for "comment-style" type annotation. Signed-off-by: Jack Cherng <[email protected]>
timfjord
approved these changes
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has been more than a month since last
lsp_utilsrelease so I guess it's safe to remove deprecatedminimum_node_version(it has been replaced byrequired_node_version).