-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong F401 error raised #747
Labels
Comments
@ocelotl please (1) search the issue tracker and (2) read the changelog for 3.0.0 |
|
tych0
added a commit
to tych0/qtile
that referenced
this issue
Nov 29, 2022
pyflakes 3.0.0 drops support for the comment style annotations, in favor of the actual syntactic version of type annotations. This gets everything to pass flake8 again, but there are still many instances of " # type" that we should fix. PyCQA/pyflakes#747 (comment)
tych0
added a commit
to qtile/qtile
that referenced
this issue
Nov 29, 2022
pyflakes 3.0.0 drops support for the comment style annotations, in favor of the actual syntactic version of type annotations. This gets everything to pass flake8 again, but there are still many instances of " # type" that we should fix. PyCQA/pyflakes#747 (comment)
tych0
added a commit
to tych0/qtile
that referenced
this issue
Nov 29, 2022
pyflakes 3.0.0 drops support for the comment style annotations, in favor of the actual syntactic version of type annotations. This gets everything to pass flake8 again, but there are still many instances of " # type" that we should fix. PyCQA/pyflakes#747 (comment) Signed-off-by: Tycho Andersen <[email protected]>
tych0
added a commit
to qtile/qtile
that referenced
this issue
Nov 29, 2022
pyflakes 3.0.0 drops support for the comment style annotations, in favor of the actual syntactic version of type annotations. This gets everything to pass flake8 again, but there are still many instances of " # type" that we should fix. PyCQA/pyflakes#747 (comment) Signed-off-by: Tycho Andersen <[email protected]>
elParaguayo
pushed a commit
to qtile/qtile
that referenced
this issue
Nov 29, 2022
pyflakes 3.0.0 drops support for the comment style annotations, in favor of the actual syntactic version of type annotations. This gets everything to pass flake8 again, but there are still many instances of " # type" that we should fix. PyCQA/pyflakes#747 (comment) Signed-off-by: Tycho Andersen <[email protected]>
lengau
added a commit
to lengau/snapcraft
that referenced
this issue
Dec 15, 2022
* Add tox >= 4.0 as a dev dependency * Add tox configuration to setup.cfg - I chose setup.cfg because pyproject.toml support in tox is awkward (tox-dev/tox#999) - Specified flake8 < 6.0.0 until we can get around to replacing type comments with type annotations. PyCQA/pyflakes#747 * Modify Makefile to use tox instead of running the commands directly * Update .gitignore for relevant new files and directories * Update requirements files - Newer tarball in freeze-requirements.sh because the older one was sometimes breaking in tox. * Set pylint configuration to ignore tests/legacy rather than manually excluding it A future commit will configure tox in Github actions.
Was this change made knowing full well that it's only possible to use annotations for variables from python 3.6 and up? I'm asking since the commit message ( |
pyflakes only supports python3.6 and above |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
This seems like a regression of #247. The example below uses
nox
.I created a directory with three files:
module_a.py
:module_b.py
:noxfile.py
:When I run
nox
, no issues are raised:When I uncomment
# session.install("flake8==6.0.0")
, commentsession.install("flake8==5.0.4")
and runnox
again, an issue is raised:The text was updated successfully, but these errors were encountered: