Feature/minor doc fixes #863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
September 7, 2017 18:58
- Do not include action on toasts/snackbars for dismiss - Use 'Ok' on alert rather than "Dismiss" - Use single word actions if possible - Duplicated in HTML and TS because of example with code sample
- Add whitespace
- add some padding on dynamic buttons so they don't get cut off in the demo.
- reduce margin on all td-paging-bar elements to prevent wrapping in demos
| @@ -0,0 +1,4 @@ | |||
| /* Set margin on all elements in td-paging-bar to 5px to prevent wrapping in examples */ | |||
| .td-paging-bar * { | |||
There was a problem hiding this comment.
hmmm i'm concerned with using custom scss in docs, it will potentially mislead users
There was a problem hiding this comment.
Adjusted to breakpoints and link count instead of padding/margin.
- Avoid custom CSS - Adjust breakpoinsts and links shown instead
|
BTW, this closes #844. Thanks @jennmedellin |
|
LGTM |
- Minor chagne to breakpoints for Paging with Everything demo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix minor margin, padding, and text issues in Covalent Docs examples.
What's included?
Test Steps
General Tests for Every PR
ng serve --aotstill works.npm run lintpasses.npm testpasses and code coverage is not lower.npm run buildstill works.Design Patterns > Alerts examples
Components > Dynamic Forms > Dyamic Boolean Elements example
Components > Paging