You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@aciccarello Hey, thanks for the great feedback! No PR needed as we just added a dedicated section for patterns. I'll be sure this makes it into the next release.
Bug Report
This is a bit nit-picky but the design pattern docs currently demonstrate toasts in a way that does not align with the Material Design spec.
Screenshots or link to CodePen/Plunker/JSfiddle
What is the expected behavior?
Snackbar example should not demonstrate a "DISMISS" action. It should show a different action such as "UNDO" and/or no action.
What is the motivation for changing the behavior?
The Material design spec specifically forbids having a dismiss action on a snackbar.
Other information
Here is the line that needs to be changed:
https://github.com/Teradata/covalent/blob/develop/src/app/components/design-patterns/alerts/alerts.component.ts#L33-L36
And in the documentation:
https://github.com/Teradata/covalent/blob/develop/src/app/components/design-patterns/alerts/alerts.component.html#L170-L172
I'd be happy to create a PR if desired.
The text was updated successfully, but these errors were encountered: