Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snackbar example should not have dismiss action #844

Closed
aciccarello opened this issue Aug 30, 2017 · 2 comments
Closed

Snackbar example should not have dismiss action #844

aciccarello opened this issue Aug 30, 2017 · 2 comments

Comments

@aciccarello
Copy link
Contributor

Bug Report

This is a bit nit-picky but the design pattern docs currently demonstrate toasts in a way that does not align with the Material Design spec.

Screenshots or link to CodePen/Plunker/JSfiddle

image

What is the expected behavior?

Snackbar example should not demonstrate a "DISMISS" action. It should show a different action such as "UNDO" and/or no action.

What is the motivation for changing the behavior?

The Material design spec specifically forbids having a dismiss action on a snackbar.

Usage

Only one snackbar may be displayed at a time. Each snackbar may contain a single action, neither of which may be “Dismiss” or “Cancel.”

Other information

Here is the line that needs to be changed:
https://github.com/Teradata/covalent/blob/develop/src/app/components/design-patterns/alerts/alerts.component.ts#L33-L36

And in the documentation:
https://github.com/Teradata/covalent/blob/develop/src/app/components/design-patterns/alerts/alerts.component.html#L170-L172

I'd be happy to create a PR if desired.

@jennmedellin
Copy link
Collaborator

@aciccarello Hey, thanks for the great feedback! No PR needed as we just added a dedicated section for patterns. I'll be sure this makes it into the next release.

@aciccarello aciccarello mentioned this issue Sep 8, 2017
4 tasks
@jennmedellin
Copy link
Collaborator

Resolved in #863 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants