Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(search): make placeholder stay in place when focused. (closes #226) #391

Merged
merged 1 commit into from
Mar 2, 2017

Conversation

emoralesb05
Copy link
Contributor

@emoralesb05 emoralesb05 commented Feb 28, 2017

Description

leverage [floatPlaceholder] to make the placeholde stay in place when focused
#226

Test Steps

General Tests for Every PR

  • ng serve --aot still works.
  • npm run lint passes.
  • npm test passes and code coverage is not lower.
  • npm run build still works.

leverage [floatPlaceholder] to make the placeholde stay in place when focused
@emoralesb05 emoralesb05 added this to the Beta 3 milestone Feb 28, 2017
Copy link
Collaborator

@richavyas richavyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@emoralesb05 emoralesb05 merged commit 58094fa into develop Mar 2, 2017
@emoralesb05 emoralesb05 deleted the feature/search-placeholder branch March 2, 2017 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants