Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Placeholder text can not appear for search bar when expanded #226

Closed
bazhip opened this issue Jan 1, 2017 · 5 comments
Closed

Placeholder text can not appear for search bar when expanded #226

bazhip opened this issue Jan 1, 2017 · 5 comments
Milestone

Comments

@bazhip
Copy link

bazhip commented Jan 1, 2017

This repository's issues are reserved for feature requests and bug reports.

Do you want to request a feature or report a bug?

bug

Feature Request

please first make sure your request falls under the official Material Design spec guidelines https://material.google.com/

Bug Report

please provide steps to reproduce and if possible screenhots or animated Gifs.
you can easily create animated Gif with this free PC/OSX App: http://www.cockos.com/licecap/

Screenshots or link to CodePen/Plunker/JSfiddle

searchbar

What is the expected behavior?

I'd think the placeholder text should appear when the search is expanded so that they know what the field is for. I ended up adding a block of text to the side for the time being until I play with it more.

What is the motivation / use case for changing the behavior?

^

Which version of Angular and Material, and which browser and OS does this issue affect?

I'm on the latest build (with 2.4.1) and using chrome

Did this work in previous versions of Angular / Material?
Please also test with the latest stable and snapshot versions.
Haven't checked the others

Other information

(e.g. detailed explanation, stacktraces, related issues, suggestions how to fix)
https://github.com/Teradata/covalent-quickstart/issues/25

@richavyas
Copy link
Collaborator

Thanks for reporting this @bazhip. we'll look into it.

@emoralesb05
Copy link
Contributor

emoralesb05 commented Jan 2, 2017

To continue what was discussed in Teradata/vantage-ui-template#25.

This works as intended, but it would be nice to make the placeholder hiding function optional when focused.

Gonna mark this as an enhancement for a future release.

@emoralesb05 emoralesb05 added this to the Beta 1 milestone Jan 2, 2017
@bazhip
Copy link
Author

bazhip commented Jan 2, 2017

That's fair. The only reason I threw it as a bug was the fact that the animations were conflicting with each other, but the end result was what was desired at planning.

Thanks guys!

@kyleledbetter
Copy link
Contributor

Since we autofocus the label/placeholder shouldn't be there. The only way something like search should technically be there is if it was the default value, but that would be weird bc you'd have to backspace to remove the text...

So this is working as intended as @emoralesb05 said.

The only reason I threw it as a bug was the fact that the animations were conflicting with each other

what did you mean by animations where conflicting @bazhip ?

@emoralesb05 emoralesb05 modified the milestones: Beta 2, Beta 1 Jan 27, 2017
@emoralesb05
Copy link
Contributor

Once material releases beta.2, it will give us the flexibility to do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants