Feature/loading improvements and bug fixes #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
August 15, 2016 22:08
…nDestroy and remove comp methods
| @@ -17,6 +17,7 @@ import { TdLayoutComponent } from '../platform/core'; | |||
| selector: 'td-docs-app', | |||
| styleUrls: ['app.component.css'], | |||
| templateUrl: 'app.component.html', | |||
| precompile: [ TD_LOADING_ENTRY_COMPONENTS ], | |||
There was a problem hiding this comment.
Haven't used precompile before but it looks like it is being renamed. The change is in angular master (Component metadata docs) and I presume RC5 so #37 will have to be updated.
There was a problem hiding this comment.
Yes, its actually just for rc4. In rc5 it uses entryComponents in ngModule. I already have that ready in #37, but we are waiting on that since rc5 and CLI have some stability issues in this release.
emoralesb05
pushed a commit
that referenced
this pull request
Jul 23, 2019
* FullScreen Mode feature * Proper name and key added for menu item * Remove extra trailing spaces * Fixed review comments. * Revert "Fixed review comments." This reverts commit 89b724c16fceb94728ce7f16b260fbe7abd24707. * Fixed review comment: Added necessary changes requested and removed whitespace changes. * UTs added for FullScreenMode feature.
emoralesb05
pushed a commit
that referenced
this pull request
Jul 25, 2019
* feat(echarts): Add treemap as a chart option to Covalent E-Charts * fix linting * removing json data file * removing config options that are handled in series component now * feat(): reformat demo example and rename TreeMap to Treemap * feat(): demo [leafDepth]="2" in treemap
kriswinbush
pushed a commit
to kriswinbush/covalent
that referenced
this pull request
Feb 20, 2020
* feat(echarts): Add treemap as a chart option to Covalent E-Charts * fix linting * removing json data file * removing config options that are handled in series component now * feat(): reformat demo example and rename TreeMap to Treemap * feat(): demo [leafDepth]="2" in treemap
kriswinbush
pushed a commit
to kriswinbush/covalent
that referenced
this pull request
Feb 20, 2020
* FullScreen Mode feature * Proper name and key added for menu item * Remove extra trailing spaces * Fixed review comments. * Revert "Fixed review comments." This reverts commit 89b724c16fceb94728ce7f16b260fbe7abd24707. * Fixed review comment: Added necessary changes requested and removed whitespace changes. * UTs added for FullScreenMode feature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Second iteration on TdLoadingDirective/Service/Component.
What's included?
widthto loading circle to be in par with circle height.NgZone#runOutsideAngularto address a bug with protractor where it gets stuck waiting when adding attaching/detaching the component and doing its animations.Known issue:
e.g.
Test Steps
ng serveGo to loading component