Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/upgrade RC6 #37

Merged
merged 72 commits into from
Sep 9, 2016
Merged

Feature/upgrade RC6 #37

merged 72 commits into from
Sep 9, 2016

Conversation

emoralesb05
Copy link
Contributor

@emoralesb05 emoralesb05 commented Aug 11, 2016

Description

Updated angular to latest releases of angular and material.
#36

What's included?

Breaking Changes

  • Upgraded to RC6
  • Upgrade material to alpha.8-1
  • Added hammerjs dependency for material.
  • Removed bootstrap and implemented everything with NgModule decorator.
  • Changed TdLoadingDirective's creation to be sync so it can be accessed in the ngAfterViewInit hook.

Bug Fixes

  • Changed code in animations since the angular classes used are no longer public and changed duration to 150ms so it doesnt look like its frozen in IE/Firefox (they dont support animations).
  • Fixed file-upload select/drop events for Firefox and IE.

Internal

  • Restructured imports in docs to remove the majority of the index.ts files and less explicit declarations in system-config.ts.
  • Unit test karma-test-shim changes to set up test environment.
  • Removed all unit tests (gonna start from scratch with each one).
  • Unit tests changes to use TestBed and remove imports describe/it/beforeEach since they are taken as global.
  • Need to add angular2-material core.css and overlay.css as a workaround for ripple and menu into index.html Weird ripple effect angular/components#972

Known Issues

  • Need to update documentation to be in par with modules

Internal Known Issues

  • --prod not working well (not even with latest CLI), need to dive in more to see if its the way modules were defined or if its actually a bug.
  • karma is not running correctly. (need to retest with RC6)

Test Steps

  • npm i
  • ng serve
  • navigate and see everything being rendered correctly and no errors shown in console.

Ed Morales added 29 commits August 9, 2016 21:06
@emoralesb05 emoralesb05 changed the title Feature/upgrade rc5 Feature/upgrade RC6 Sep 9, 2016
@emoralesb05 emoralesb05 merged commit 6104b55 into develop Sep 9, 2016
@emoralesb05 emoralesb05 deleted the feature/upgrade-rc5 branch September 9, 2016 22:17
@emoralesb05 emoralesb05 added this to the Alpha 0.7 milestone Sep 12, 2016
emoralesb05 added a commit that referenced this pull request Jul 25, 2019
* perf(chart): make sure only to render chart when necessary

add a debounce and combine all options fed by subcomponents to render the chart only once.. before it was rerendered multiple times depending on changes on subcomponents

* fix(): remove xAxis/yAxis from demo in tree/treemap

* fix(): make demo fit screen better in treemap

* fix(): change readme
kriswinbush pushed a commit to kriswinbush/covalent that referenced this pull request Feb 20, 2020
* perf(chart): make sure only to render chart when necessary

add a debounce and combine all options fed by subcomponents to render the chart only once.. before it was rerendered multiple times depending on changes on subcomponents

* fix(): remove xAxis/yAxis from demo in tree/treemap

* fix(): make demo fit screen better in treemap

* fix(): change readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants