-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature(dependencies): add @angular/flex-layout (closes #239) #334
Conversation
for the time being, we will be fixed to a specific version since its a beta release.
Code & UX LGTM 👍 I've got questions more around the performance & cascading implications of flex-layout using inline styles instead of CSS stylesheets, that are mainly just unknowns for me, since we use flex layout not only for layouts but for every single UI element. That's a ton of extra inline HTML styles... Obviously I can see all the benefits of this being in JavaScript with all the power of Angular2 with media queries, change detection, etc, which is why I'm excited about it I'll do more research from their wiki and more testing on my own. |
@kyleledbetter - I started using What I ended up settling on was using All the low level styles for components I ended up moving back to .css, not so much because of a performance issue but simply because the bloat in my HTML styles was messing with my OCD. @emoralesb05 - I played around with fxFlex in Covalent before I opened #239 so I have most of it converted all be it out of date. The approach I took personally was to just replace existing tags with their From Kyle's comment it sounds like that approach would be optimal to kind of ease into the pool before heading out to the media query deep end. I can PR that in once the basic support lands assuming the above is accurate. |
@d3viant0ne Yeah, it feels like we might have a need for both things to coexist for now. I still think its greatly needed (it has awesome features) but we might stick to ours for internal usage in our components and use |
@emoralesb05 i'm cool with merging in for use if we revert search & paging to use the css classes, that way we can do more testing downstream in products |
@kyleledbetter yep, will revert those so we can just merge it |
Description
Including
@angular/flex-layout
as part ofCovalentCoreModule
and started initial migration to leverage it. #239This is meant to show both
flex
libs can co-exist incovalent
as we migrate into@angular/flex-layout
.For the time being, we will be fixed to a specific version since its a beta release. (beta.5)
What's included?
@angular/flex-layout
as as a@covalent/core
dependencyTest Steps
npm reinstall
ng serve
@angular/flex-layout
anywhere in docs.General Tests for Every PR
ng serve --aot
still works.npm run lint
passes.npm test
passes and code coverage is not lower.npm run build
still works.