Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade @angular/flex-layout to beta8 #542

Closed
jraadt opened this issue Apr 30, 2017 · 2 comments · Fixed by #567
Closed

Upgrade @angular/flex-layout to beta8 #542

jraadt opened this issue Apr 30, 2017 · 2 comments · Fixed by #567
Labels
dependencies
Milestone
Beta 4

Comments

@jraadt
Copy link

jraadt commented Apr 30, 2017

This repository's issues are reserved for feature requests and bug reports.

Do you want to request a feature or report a bug?

bug

Bug Report

Cannot build app using Angular CLI with Angular CLI 1.0 and Angular 4.0. @angular/flex-layout dependency inside Covalent is currently at beta7, which does not work with Angular 4 building, but it has been fixed in beta8.

The error I currently get is:
ERROR in Error encountered resolving symbol values statically. Calling function 'makeDecorator', function calls are not supported. Consider replacing the function or lambda with a reference to an exported function, resolving symbol NgModule in /myapp/node_modules/@covalent/core/node_modules/@angular/flex-layout/node_modules/@angular/core/src/metadata/ng_module.d.ts, resolving symbol NgModule in /myapp/node_modules/@covalent/core/node_modules/@angular/flex-layout/node_modules/@angular/core/src/metadata.d.ts, resolving symbol NgModule in /myapp/node_modules/@covalent/core/node_modules/@angular/flex-layout/node_modules/@angular/core/src/core.d.ts, resolving symbol NgModule in /myapp/node_modules/@covalent/core/node_modules/@angular/flex-layout/node_modules/@angular/core/index.d.ts, resolving symbol FlexLayoutModule in /myapp/node_modules/@covalent/core/node_modules/@angular/flex-layout/flexbox/_module.d.ts, resolving symbol FlexLayoutModule in /myapp/node_modules/@covalent/core/node_modules/@angular/flex-layout/flexbox/_module.d.ts
@emoralesb05
Copy link
Contributor

Thanks for the issue! We are actually gonna remove the dependency since CovalentCoreModule has been deprecated and there is no real use for that module internally.

@emoralesb05 emoralesb05 added this to the Beta 4 milestone May 1, 2017
@aciccarello
Copy link
Contributor

Related #239 and #334

@emoralesb05 emoralesb05 mentioned this issue May 7, 2017
Merged
6 tasks
emoralesb05 added a commit that referenced this issue May 7, 2017
@emoralesb05
chore(dependencies): removal of flex-layout dependency. (closes #542) (…
a15d493 
…closes #502) (#567)

* chore(dependencies): removal of flex-layout dependency

since CovalentCoreModule has been removed, there is really no use for @angular/flex-layout inernally. we will leave it to the developer to include it on demand.

* chore(): update yarn.lock with latest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies
Projects
None yet
Milestone
Beta 4
3 participants
@jraadt @emoralesb05 @aciccarello