-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(data-table): split data-table into atomic reusable components + theming #128
Conversation
Oh, yeah. Ill change that later on haha |
|
Might be nice to have docs around custom columns like you did here:
|
and also docs explaining how to use the other paging/search components with the datatable
|
*/ | ||
@Output('rowSelect') onRowSelect: EventEmitter<ITdDataTableSelectEvent> = new EventEmitter<ITdDataTableSelectEvent>(); | ||
|
||
clearModel(): void { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe add a comment to what this method is doing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually this file has bunches of methods in it that probably need docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, ill add more comments around the code to make it easier to review 😄
} else { | ||
setTimeout(this.clearSearch.bind(this)); | ||
if (this.uniqueId) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should probably add a comment around this section explaining what is going on in this
Description
There is a need to use data-table in many different situations, so besides providing a
<data-table>
component that does some of the things, its better to have atomic components so the consumer can create their custom data-table with them (atoms to build a molecule).What's included?
Usage:
<td-data-table>
still works, but most of the things were abstracted from it and there are components created from those abstractions (td-search-box
,td-paging-bar
andTdDataTableService
(TdDataTableService
contains the local sorting/paging/searching logic).<td-data-table>
data-table
module included with@include covalent-theme($theme)
.lodash
as dependency.data-table
module.rowSelect
event when clicking on a row in<td-data-table>
Test Steps
ng serve
Screenshots or link to CodePen/Plunker/JSfiddle
Screenshots with paging-bar + search-box + tdDataTableService