Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Data Table Sort Order for Numeric Data #115

Closed
fxstein opened this issue Oct 24, 2016 · 5 comments
Closed

Incorrect Data Table Sort Order for Numeric Data #115

fxstein opened this issue Oct 24, 2016 · 5 comments
Labels
Milestone

Comments

@fxstein
Copy link

fxstein commented Oct 24, 2016

Bug Report

Data Table component does not sort numeric data correctly.
As seen here: https://teradata.github.io/covalent/#/components/data-table

Screenshots or link to CodePen/Plunker/JSfiddle

screen shot 2016-10-24 at 11 07 53 am

What is the expected behavior?

When sorting a numeric column, smaller number should come before larger number when sorted ascending and vice versa.

Hope this helps!

@emoralesb05
Copy link
Contributor

emoralesb05 commented Oct 24, 2016

Huh, its doing string sorting instead of numeric sorting.
Sorry we didnt notice this before, i will add this as a priority for this release.

Thanks for letting us know!

@emoralesb05 emoralesb05 added this to the Alpha 0.9 milestone Oct 24, 2016
@emoralesb05
Copy link
Contributor

Fixed in #128 while abstracting the local sort into TdDataTableService

@fxstein
Copy link
Author

fxstein commented Nov 14, 2016

Thank you!

@zeeshangithub
Copy link

i need some help about integrating covalent in ng2 manually

@emoralesb05
Copy link
Contributor

You can ask in our gitter channel for support questions or additional info.

https://gitter.im/Teradata/covalent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants