Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(): upgrade ng-packagr from 2.0.0-rc.10 to 2.0.0 stable #1113

Merged
merged 3 commits into from
Feb 6, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,6 @@
- [ ] `npm run tslint` passes.
- [ ] `npm run stylelint` passes.
- [ ] `npm test` passes and code coverage is not lower.
- [ ] `npm run build:release` still works.
- [ ] `npm run build:lib` still works.

##### Screenshots or link to StackBlitz/Plunker
4 changes: 2 additions & 2 deletions docs/RELEASE.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
1. Notifications need to be updated in the covalent `home` screen.
2. Make sure the `platform` `package.json`s point to the correct versions.
3. `ng serve --aot` works fine.
4. `npm run build:release` works fine.
4. `npm run build:lib` works fine.

#### Start Release

Expand Down Expand Up @@ -43,7 +43,7 @@ Execute `npm run release:finish -- [version]` to finish the release process. The
#### Publish Release

Execute `npm run publish:npm` from develop branch to start the automatic publishing process. The steps executed are:
1. Executes `npm run build:release` process.
1. Executes `npm run build:lib` process.
2. Executes `bash scripts/npm-publish` process.

#### Post Release Checklist
Expand Down
9 changes: 5 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,10 @@
"serve": "node --max_old_space_size=5048 ./node_modules/@angular/cli/bin/ng serve",
"serve:prod": "node --max_old_space_size=5048 ./node_modules/@angular/cli/bin/ng serve --aot --prod --sourcemap=false --build-optimizer",
"build:docs": "node --max_old_space_size=5048 ./node_modules/@angular/cli/bin/ng build --aot --prod --sourcemap=false --build-optimizer",
"build:release": "bash scripts/build-release",
"build:lib": "bash scripts/build-release",
"build:universal": "bash scripts/build-universal",
"publish:npm": "npm run build:release && bash scripts/npm-publish",
"publish:nightly": "npm run build:release && bash scripts/nightly-publish",
"publish:npm": "npm run build:lib && bash scripts/npm-publish",
"publish:nightly": "npm run build:lib && bash scripts/nightly-publish",
"ghpages:deploy": "npm run build:docs -- --base-href /covalent/ && bash scripts/ghpages-deploy",
"release:start": "bash scripts/start-release",
"release:finish": "bash scripts/finish-release",
Expand Down Expand Up @@ -128,7 +128,7 @@
"karma-jasmine-html-reporter": "^0.2.2",
"karma-phantomjs-launcher": "1.0.1",
"merge2": "1.0.2",
"ng-packagr": "2.0.0-rc.10",
"ng-packagr": "2.0.0",
"node-sass": "3.8.0",
"pa11y": "^5.0.0-beta.5",
"protractor": "~5.1.0",
Expand All @@ -139,6 +139,7 @@
"semver": "5.2.0",
"stylelint": "^8.4.0",
"ts-node": "^3.0.4",
"tsickle": "^0.26.0",
"tslint": "5.2.0",
"typescript": "~2.6.2",
"uglify-js": "^2.8.14",
Expand Down
2 changes: 1 addition & 1 deletion scripts/build-universal
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
set -e

# build and test ssr in universal app
npm run build:release
npm run build:lib
rm -rf .td_test_universal
rm -f deploy/platform/core/covalent-core-*.tgz

Expand Down
2 changes: 1 addition & 1 deletion scripts/ci/travis-script.sh
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ if [ "${MODE}" = "lint" ]; then
elif [ "${MODE}" = "aot" ]; then
npm run build:docs
elif [ "${MODE}" = "release" ]; then
npm run build:release
npm run build:lib
elif [ "${MODE}" = "unit-test" ]; then
npm run test
elif [ "${MODE}" = "a11y" ]; then
Expand Down
2 changes: 1 addition & 1 deletion scripts/start-release
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ echo "Execute unit tests"
npm run test

echo "Execute release build test"
npm run build:release
npm run build:lib
rm -rf deploy

echo "Bump to version v$version"
Expand Down
Loading