Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(): upgrade ng-packagr from 2.0.0-rc.10 to 2.0.0 stable #1113

Merged
merged 3 commits into from
Feb 6, 2018

Conversation

ghost
Copy link

@ghost ghost commented Feb 6, 2018

Description

Upgraded ng-packagr

What's included?

  • Upgraded ng-packagr from 2.0.0-rc.10 to stable 2.0.0

Test Steps (Covalent build/test)

  • Verify you are using node v8.9.x
  • npm run reinstall
  • To make the next steps a little easier go to scripts/build-release and add this code to the bottom of the file to npm pack instead of doing it manually:
cd deploy/platform/core
npm pack
cd ../dynamic-forms
npm pack
cd ../highlight
npm pack
cd ../http
npm pack
cd ../markdown
npm pack
  • Verify npm run serve works accordingly. Test all components http://localhost:4200/
  • run npm run build:release

Test Steps (Product build)

  • Clone AppCenter repo into the directory above this one.
  • yarn cache clean
  • yarn install
  • yarn remove @covalent/core
  • yarn remove @covalent/highlight
  • yarn remove @covalent/http
  • yarn remove @covalent/markdown
  • yarn add <file-path-to-*.tgz> repeat for (core, highlight, http, markdown respectively) (EX: yarn add ../covalent/deploy/platform/core/covalent-core-1.0.0-rc.4.tgz)
  • npm rebuild node-sass
  • yarn upgrade @angular/material
  • yarn upgrade @angular/cdk
  • Verify you are using node v8.9.x.
  • Verify npm run serve works correctly
  • Verify ./node_modules/@angular/cli/bin/ng build --aot --prod --sourcemap=false --build-optimizer successfully runs
  • Verify ./node_modules/@angular/cli/bin/ng serve --aot --prod --sourcemap=false --build-optimizer --proxy-config proxy.conf.json successfully runs and you can access the local site http://localhost:4200/
  • Modify the import paths (primary/secondary entry point usage) in app.module and trying the prod build again it should run successfully.

General Tests for Every PR

  • npm run serve:prod still works.
  • npm run tslint passes.
  • npm run stylelint passes.
  • npm test passes and code coverage is not lower.
  • npm run build:release still works.

closes #1099

@ghost ghost changed the title chore(): upgrade ng-packagr from 2.0.0-rc.10 to 2.0.0-rc.13 chore(): upgrade ng-packagr Feb 6, 2018
@ghost ghost changed the title chore(): upgrade ng-packagr chore(): upgrade ng-packagr to 2.0.0 stable Feb 6, 2018
@ghost ghost changed the title chore(): upgrade ng-packagr to 2.0.0 stable chore(): upgrade ng-packagr from 2.0.0-rc.10 to 2.0.0 stable Feb 6, 2018
@emoralesb05 emoralesb05 merged commit 0d32983 into develop Feb 6, 2018
@emoralesb05 emoralesb05 deleted the feature/upgrade-ng-packagr branch February 6, 2018 23:54
@emoralesb05 emoralesb05 added this to the Next Release milestone Feb 6, 2018
kriswinbush pushed a commit to kriswinbush/covalent that referenced this pull request Feb 20, 2020
* chore(): upgrade ng-packagr from 2.0.0-rc.10 to 2.0.0-rc.13

* chore(): upgrade ng-packager to 2.0.0 stable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ng build --prod error with rc3
1 participant