Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stuck while destroying instance #1023

Closed
jbaenaxd opened this issue May 28, 2024 · 6 comments · Fixed by #1039
Closed

Stuck while destroying instance #1023

jbaenaxd opened this issue May 28, 2024 · 6 comments · Fixed by #1039
Assignees
Labels
type/enhancement An improvement of existing functionality

Comments

@jbaenaxd
Copy link

Sometimes, I want to destroy an instance because there's a problem with the installation or some processes are blocked. It seems that the behaviour for this destroying a VM is to send a shutdown signal. Why not a stop signal? Anyway we are gonna destroy it, better to do it faster. If the VM state is unstable, the shutdown signal will fail and the destroy action can't be performed, after that, I have to cancel the shutdown action and send a stop action to let the destruction to continue.

Proposed action:

  • Change VM destroy action from shutdown to stop
@Tinyblargon Tinyblargon added the type/enhancement An improvement of existing functionality label May 28, 2024
@Tinyblargon Tinyblargon self-assigned this Jun 9, 2024
This was referenced Jun 9, 2024
Tinyblargon added a commit that referenced this issue Jun 9, 2024
feat: stop VM when deleting
@k-w-d-e
Copy link

k-w-d-e commented Nov 15, 2024

Problem does not seem to be fixed.

Running terraform destroy wont forcefully stop the VM.

I've waited >10min and in Proxmox Tasks log i see 'Description: VM - Shutdown' and Status is a rotating circle.

I too am trying to 'destroy' a running installation process.

@TomyLobo
Copy link

Someone reintroduced this issue in between 3.0.1-rc3 and 3.0.1-rc4, 5 months ago:
641d096#diff-104365919f693375882979581d9f36f5266991eef361948e56c220931fe886ddL1615

@TomyLobo
Copy link

This looks like changes between 3.0.1-rc2 and 3.0.1-rc3 were accidentally reverted in 3.0.1-rc4, as part of that commit.
@Tinyblargon, on the off-chance that this isn't the only change, can you take a look at the commit I linked and see if you accidentally reverted anything else?

@emoxam
Copy link

emoxam commented Nov 28, 2024

Well, any news ?
Destroying stuck at the shutdown..

@Tinyblargon
Copy link
Collaborator

@emoxam could you create a mew issue and post the debug log?

In RC6 it does a stop instead of a shutdown.
Terraform always has to do a preliminary read operation, that might be hanging.

@emoxam
Copy link

emoxam commented Nov 28, 2024

@Tinyblargon RC6 seems to work! I was using RC4.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants