Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Header): bleed not working in o2-new skin #1137

Merged
merged 4 commits into from
Jun 5, 2024
Merged

Conversation

atabel
Copy link
Collaborator

@atabel atabel commented Jun 3, 2024

jira: WEB-1700

@atabel atabel marked this pull request as ready for review June 3, 2024 07:28
Copy link

github-actions bot commented Jun 3, 2024

Size stats

master this branch diff
Total JS 10.7 MB 10.7 MB +6 B
JS without icons 1.95 MB 1.95 MB +6 B
Lib overhead 53.8 kB 53.8 kB 0 B
Lib overhead (gzip) 14.4 kB 14.4 kB 0 B

Copy link

github-actions bot commented Jun 3, 2024

Accessibility report
✔️ No issues found

ℹ️ You can run this locally by executing yarn audit-accessibility.

Copy link

github-actions bot commented Jun 3, 2024

Deploy preview for mistica-web ready!

✅ Preview
https://mistica-9sebtae6y-flows-projects-65bb050e.vercel.app

Built with commit 100156e.
This pull request is being automatically deployed with vercel-action

Copy link
Member

@pladaria pladaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no screenshot updates?

@atabel
Copy link
Collaborator Author

atabel commented Jun 4, 2024

no screenshot updates?

There isn't any screenshot of this component for o2-new skin.
I could include it in the private-skin-components-screenshot-test

@atabel atabel enabled auto-merge June 5, 2024 13:56
@atabel atabel added this pull request to the merge queue Jun 5, 2024
Merged via the queue into master with commit 00fb632 Jun 5, 2024
11 checks passed
@atabel atabel deleted the atoledano-header-o2-new branch June 5, 2024 14:15
tuentisre pushed a commit that referenced this pull request Jun 19, 2024
# [15.11.0](v15.10.0...v15.11.0) (2024-06-19)

### Bug Fixes

* **ButtonLayout:** add bleed when using only link ([#1150](#1150)) ([554f98a](554f98a))
* **Counter:** add aria-live to value ([#1146](#1146)) ([3e2e09b](3e2e09b))
* **Header:** bleed not working in o2-new skin ([#1137](#1137)) ([00fb632](00fb632))
* **MainNavigationBar:** remove logo space in mobile when no sections are given ([#1149](#1149)) ([e4c03a0](e4c03a0))
* **Select:** set text color in native version ([#1141](#1141)) ([eedf265](eedf265))
* **Spinner:** use controlActivatedInverse token as default when used inside inverse variant ([#1133](#1133)) ([38a192d](38a192d))

### Features

* **Cards:** improve accessibility ([#1139](#1139)) ([dde9cc5](dde9cc5))
* **Chip:** allow using badge in selectable chips ([#1134](#1134)) ([9ecda7c](9ecda7c))
* **Circle:** custom background support ([#1136](#1136)) ([bedeaa4](bedeaa4))
* **CoverHero:** new component ([#1144](#1144)) ([a655e6e](a655e6e))
* **DisplayMediaCard, PosterCard:** add extra ([#1131](#1131)) ([501cf73](501cf73))
* **EmptyState:** allow using only ButtonLink as action ([#1140](#1140)) ([d73c219](d73c219))
* **HighlightedCard:** support for alt for image ([#1135](#1135)) ([c9ba728](c9ba728))
* **Image:** Custom fallback icon in Vivo New ([#1145](#1145)) ([ec600fe](ec600fe))
* **Switch:** Improve animation ([#1142](#1142)) ([8162eed](8162eed))
* **Table:** new component ([#1129](#1129)) ([328e013](328e013))
* **Timer:** create component ([#1130](#1130)) ([0b3253e](0b3253e))
* **Touchable:** newTab support in to links ([#1143](#1143)) ([eff07e3](eff07e3))
@tuentisre
Copy link
Collaborator

🎉 This PR is included in version 15.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants