-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cdr3 nucleotide sequences #73
Conversation
This directory is necessary for IgBLAST CDR3 calling
Thanks @dcroote! Couple of questions:
Thanks again. Happy to discuss any of these points. Mike |
Thanks for taking a look @mstubb ! Here are the answers:
|
Looks great, thanks. One more thing has occurred to me. At the moment, when the |
Sure! I'll have the changes done within the next couple days. |
Should be all set! The amino acid CDR3 sequences are reported in the
as well as the
|
Cool, thanks! This looks great. I have a couple more thoughts / questions:
I'd be interested to hear your thoughts. |
|
Hey Derek I've been testing this out on a set of ~150 cells, using your updated Docker image. The output looks exactly the same as the standard Tracer output, ie. I'm missing |
Hmm. It is working on my end. @lincoln-harris did you pull the
I get:
|
ah ok. I just did |
Hi @dcroote, I’m now on vacation so I’ll look at this properly when I’m back. But, i think lowercase for non-productive sequences would be great to help avoid any cognitive dissonance. Thanks! Mike |
Sounds good- non-productive CDR3 sequences are now lowercase. For
and for
|
Great thanks! Two more small things then I think we're ready to merge.
Mike |
Thanks, both updated! |
Thanks @dcroote! This is awesome :) |
My pleasure! Looks like the updates still need to be pushed to Docker Hub though. |
Thanks for the reminder. Repo updates are supposed to trigger new docker builds automatically but we've never got it to work. I've manually started a build so it should be updated on Dockerhub soon. |
Fixes #46 . This PR adds the the CDR3 nucleotide sequence reported by IgBLAST to tracer
assemble
andsummarise
outputs. The following walks through changes I've made usingtracer test
as an example. I've also tested the updated Docker image based on this branch for functionality usingtracer test
, some of my cells, and an empty cell.I've updated the
Dockerfile
to download and unzip the necessaryoptional_file
IgBLAST directory to where theIGDATA
environmental variable is set indocker_helper_files/docker_wrapper.sh
. IgBLAST will then report the sequence as a separate chunk within the-outfmt 7
output. For example:(From
cell1/IgBLAST_output/cell1_TCR_A.IgBLASTOut
)This is then parsed in the
process_chunk
function oftracer_func.py
and included in a newRecombinant
class attributecdr3nt
. Finally, the sequence is reported in the(un)filtered_TCR_seqs/(un)filtered_TCRs.txt
outputs as a new line for each recombinant:The CDR3 is also reported in the
summarise
outputrecombinants.txt
:Note that the code is backwards compatible:
cell2
andcell3
in thetest_data
folder come pre-processed and consequently haveN/A
as the CDR3 sequence.